Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add state parameter to queueSpec and queueStatus for queue #508

Merged
merged 2 commits into from
Nov 5, 2019
Merged

Add state parameter to queueSpec and queueStatus for queue #508

merged 2 commits into from
Nov 5, 2019

Conversation

sivanzcw
Copy link
Contributor

@sivanzcw sivanzcw commented Nov 4, 2019

  • In order to subsequently manage queue through the state of queue, add state parameter to queue struct

  • Add valid queue states

  • Add update queue logic to queue controller, when queue state changes the state of queue can be refreshed

@volcano-sh-bot volcano-sh-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 4, 2019
@TravisBuddy
Copy link

Hey @sivanzcw,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: e29bf680-fef7-11e9-b5b5-d568244b8b3c

k82cn
k82cn reviewed Nov 5, 2019
View reviewed changes
pkg/apis/scheduling/types.go Outdated
}

// QueueSpec represents the template of Queue.
type QueueSpec struct {
Weight int32
Capability v1.ResourceList
// State controller the status of queue
State string
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/string/QueueState/g

@volcano-sh-bot volcano-sh-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 5, 2019
@k82cn
Copy link
Member

k82cn commented Nov 5, 2019

/lgtm
/approve

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 5, 2019
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k82cn, sivanzcw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 5, 2019
@TravisBuddy
Copy link

Hey @sivanzcw,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 6bc072b0-ffa2-11e9-b0ee-092ac02b7026

@TravisBuddy
Copy link

Hey @sivanzcw,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 32c27e30-ffa3-11e9-b0ee-092ac02b7026

@TravisBuddy
Copy link

Hey @sivanzcw,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: e37ca660-ffa3-11e9-b0ee-092ac02b7026

@sivanzcw sivanzcw changed the title Add state parameter for queue Add state parameter to queueSpec and queueStatus for queue Nov 5, 2019
@TravisBuddy
Copy link

Hey @sivanzcw,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 8cfa50e0-ffb1-11e9-b0ee-092ac02b7026

@volcano-sh-bot volcano-sh-bot merged commit 8158df8 into volcano-sh:master Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k82cn k82cn k82cn left review comments

@hzxuzhonghu hzxuzhonghu Awaiting requested review from hzxuzhonghu

Assignees

@k82cn k82cn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sivanzcw @TravisBuddy @k82cn @volcano-sh-bot